Seems like getFloatingProps can take "tabIndex: undefined" as an opti…

…on, reducing the amount of code we need to change.
navikt · Sep 22, 2023 · 3d04aef · 3d04aef
1 parent a524196
commit 3d04aef
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/@navikt/core/react/src/popover/Popover.tsx b/@navikt/core/react/src/popover/Popover.tsx
@@ -203,24 +203,22 @@ export const Popover = forwardRef<HTMLDivElement, PopoverProps>(
       left: "right",
     }[flPlacement.split("-")[0]];
 
-    const floatingProps = getFloatingProps({
-      ref: floatingRef,
-      style: {
-        position: strategy,
-        top: y ?? 0,
-        left: x ?? 0,
-      },
-    });
-    delete floatingProps.tabIndex;
-
     return (
       <div
         className={cl("navds-popover", className, {
           "navds-popover--hidden": !open || !anchorEl,
         })}
         data-placement={flPlacement}
         aria-hidden={!open || !anchorEl}
-        {...floatingProps}
+        {...getFloatingProps({
+          ref: floatingRef,
+          style: {
+            position: strategy,
+            top: y ?? 0,
+            left: x ?? 0,
+          },
+          tabIndex: undefined,
+        })}
         {...rest}
       >
         {children}