🏷️ Conditional ExpansionCard-prop #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c1f60f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
JulianNymark
approved these changes
Apr 27, 2023
| } | ||
|
|
||
| type ExpansionCardConditionalProps = |
There was a problem hiding this comment.
type ValueOf<Obj> = Obj[keyof Obj];
type OneOnly<Obj, Key extends keyof Obj> = {
[key in Exclude<keyof Obj, Key>]+?: null;
} & Pick<Obj, Key>;
type OneOfByKey<Obj> = { [key in keyof Obj]: OneOnly<Obj, key> };
type OneOf<Obj> = ValueOf<OneOfByKey<Obj>>;
type ExpansionCardConditionalProps = OneOf<{
["aria-label"]: string;
["aria-labelledby"]: string;
}>;
funker, men er ikke "perfect" feil melding fra TS heller, men den viser i hvert fall valgmulighetene (ser fortsatt ut til å vise siste gyldige verdi i nederste linje.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tilbyr muligheten til å sette aria-label eller aria-labelledby. En av dem må være satt, så er brukt conditionals
Resolves #1931