Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] aksel stylelint #1973

Merged
merged 78 commits into from
May 31, 2023
Merged

[WIP] aksel stylelint #1973

merged 78 commits into from
May 31, 2023

Conversation

JulianNymark
Copy link
Contributor

@JulianNymark JulianNymark commented May 10, 2023 •
edited by KenAJoh
Loading

@JulianNymark JulianNymark requested a review from KenAJoh May 10, 2023 13:56
@changeset-bot
Copy link

changeset-bot bot commented May 10, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: b2a0971

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@navikt/aksel-stylelint Minor
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/ds-css-internal Minor
@navikt/ds-react-internal Minor
@navikt/ds-codemod Minor
@navikt/aksel-icons Minor
@navikt/aksel Minor
@navikt/ds-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JulianNymark
Copy link
Contributor Author

something is up with stylelint plugin definition, was hoping we could wrap all our rules in one nice plugin, but it might have to become a large list of rules in the main package.json (under "stylelint" section)

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023 •
edited
Loading

9900fae1f | 45 komponenter | 266 stories

@KenAJoh
Copy link
Collaborator

KenAJoh commented May 10, 2023

Its alive! 🧟

@macbruker
Copy link
Contributor

Hvordan skiller dette seg fra plugins som stylelint-value-no-unknown-custom-properties ?

@JulianNymark
Copy link
Contributor Author

JulianNymark commented May 16, 2023 •
edited
Loading

@macbruker

Hvordan skiller dette seg fra plugins som stylelint-value-no-unknown-custom-properties ?

Hei, den regelen gir en del overlap og er mer generisk i de tilfeller man bare refererer til en token som ikke finnes i det hele tatt, men den kan I de tilfeller for tokens man definerer og bruker en token selv sjekke om du har en skrivefeil eller av en eller annen grunn refererer til en design system token som ikke finnes (selv om selve tokenen finnes). Dette skjer med feks override + bruk (skjermbilde under).

image

I tillegg til referanser, så sjekker den navn av tokens når man overrider (re-definerer) en token.

/*...*/
  --a-illegal-token: 5px;
/*...*/

@JulianNymark
Copy link
Contributor Author

JulianNymark commented May 23, 2023 •
edited
Loading

Need to test manual upload to NPM (and dload + use).

before merge:

  • remove lint:css script
  • remove TESTLINTER.css
  • disable / ignore our own rules (do not run on design system itself?)
  • changeset file (huddle on this + versions, are they needed in reality?)

@JulianNymark
rebased
1018811
@JulianNymark
rebase
0f34404
@JulianNymark
working stylelint config + test rule
0c958d6 
this commit is a good "base" for developing future stylelint rules
@JulianNymark
merge ideas (sortof)
3ec4624
JulianNymark and others added 26 commits May 30, 2023 14:59
@JulianNymark
Merge branch 'aksel-linting' of github.com:navikt/aksel into aksel-li…
50d1b55 
…nting
@JulianNymark
fix meta name / ruleName -> ruleNamePackage refactor
45b3c05
@JulianNymark
set internal dependencies (build time)
2332a44
@JulianNymark
set internal dependencies (build time)
d2edb66
@JulianNymark
when building stylelint, always pull latest css & token files
30c61a3
@JulianNymark
new lock
3660fe5
@JulianNymark
test cache-busting
1a639b4
@JulianNymark
ignore some lint rules
5aa6a25
@JulianNymark
deduplicate rulename
4c55f95
@JulianNymark
bring back caching in ci.yml
9a7a743
@KenAJoh
📝 Oppdatert Package.json docs
6acb8c9
@KenAJoh
Merge branch 'aksel-linting' of https://github.com/navikt/aksel into …
386ae12 
…aksel-linting
@JulianNymark
more helpful error messages
daaeaec
@KenAJoh
Merge branch 'main' into aksel-linting
61ac6d0
@KenAJoh
📝 Updated readme
331e7d9
@KenAJoh
📝 Updated prefixes for rules in readme
482fa62
@JulianNymark
Merge branch 'aksel-linting' of github.com:navikt/aksel into aksel-li…
b41c9b7 
…nting
@KenAJoh
📝 Formateringsfeil i readme
d50f570
@KenAJoh
Merge branch 'aksel-linting' of https://github.com/navikt/aksel into …
bd068e6 
…aksel-linting
@JulianNymark
refactor ruleNames (shorter and better!)
fcd30ff
@JulianNymark
Merge branch 'aksel-linting' of github.com:navikt/aksel into aksel-li…
7d40a04 
…nting
@JulianNymark
update one more rule name (I forgor)
1f43c11
@JulianNymark
refactor names again (must have namespace)
7bb8aa5
@KenAJoh
🐛 Fikset intern bruk av lint-regler
e0533b2
@KenAJoh
Merge branch 'main' into aksel-linting
1c8d70f
@KenAJoh
⬆️ yarn lock sync
b2a0971
KenAJoh
KenAJoh approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢 🇮🇹

@navikt/aksel-stylelint/package.json Outdated Show resolved Hide resolved
@navikt/aksel-stylelint/package.json Show resolved Hide resolved
@navikt/aksel-stylelint/src/recommended.ts Outdated Show resolved Hide resolved
@navikt/aksel-stylelint/src/rules/aksel-design-token-exists/index.ts Outdated Show resolved Hide resolved
@navikt/aksel-stylelint/package.json Outdated Show resolved Hide resolved
@JulianNymark JulianNymark merged commit 61c4114 into main May 31, 2023
@JulianNymark JulianNymark deleted the aksel-linting branch May 31, 2023 12:22
@github-actions github-actions bot mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenAJoh KenAJoh KenAJoh approved these changes

Assignees
No one assigned
Labels
Ready for review 🧙
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JulianNymark @KenAJoh @macbruker @HalvorHaugan