Migrate CopyButton from deprecated to modern clipboard #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c274026 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cskrov
force-pushed
the
modernize-copy-function
branch
from
e11094a to
c274026
Compare
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrerer
CopyButtontilClipboard API.Vi opplever at
CopyButtonikke alltid fungerer i Chrome.Å migrere til
Clipboard API, eller mer spesifiktwriteText, fikser problemet i Chrome.Testet OK i Chrome, Firefox og Safari på MacOS og Chrome og Firefox på Linux.
PRen fjerner også en del utdatert kode og lar
window.prompt()være eneste fallback for de som bruker Internet Explorer.execCommand()er deprecated.Clipboard API, spesieltwriteTextsomCopyButtontrenger. Se Can I use.Screen recording fra Chrome som viser problemet vi opplever med
CopyButton:copybutton-issue.mov