Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update links #2093

Merged
merged 24 commits into from
Aug 9, 2023
Merged

update links #2093

merged 24 commits into from
Aug 9, 2023

Conversation

JulianNymark
Copy link
Contributor

@JulianNymark JulianNymark commented Jul 4, 2023

Description

https://github.com/navikt/team-aksel/issues/166

Change summary

Update the way links look when inlined, as well as how SVG inside links are rendered. CSS changes to all links need to be carefully reviewed!

PR Checklist 📝 (Remove fields after check!)

Documentation 📝

  • Create/Update documentation in sanity if needed
    Note: Props, tokens and examples only updates to sanity on merge to main

Versioning 🏷️

  • Breaking changes also needs documentation under "Migration"-page on website

@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2023

🦋 Changeset detected

Latest commit: 4eac6c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-css Minor
@navikt/ds-react Minor
@navikt/aksel-stylelint Minor
@navikt/aksel Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Endringer til review: 2

dc18ff574 | 47 komponenter | 301 stories

@navikt/core/css/link.css Outdated Show resolved Hide resolved
@KenAJoh
Copy link
Collaborator

KenAJoh commented Aug 7, 2023

Har tenkt litt på bruken av Link og ser det er en del tilfeller der man ønsker man har flex:
Screenshot 2023-08-07 at 10 34 32
Screenshot 2023-08-07 at 10 34 36
Dette er gjerne i tilfeller der man lenken fungerer på mange måter som en knapp, men har utrykket til en lenke.

Lurer da på om det har vært best at "non"-flex varianten var opt-in med en prop? Ikke sikker på prop navn, f.eks bare inline? Fordelen er at det ikke blir en breaking change heller da, noe som vil ha en del fordeler siden komponenten er en av de mest brukte vi har 👀

@navikt/core/css/link.css Outdated Show resolved Hide resolved
JulianNymark and others added 6 commits August 9, 2023 14:28
Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
@JulianNymark JulianNymark merged commit 267799c into main Aug 9, 2023
@JulianNymark JulianNymark deleted the inline-link branch August 9, 2023 13:00
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants