Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete should keep upper-/lowercase from the word being autocompleted #2207

Conversation

it-vegard
Copy link
Contributor

Description

Fixes #2181

Change summary

  • Combobox autocomplete now changes upper-/lowercase to match the autocompleted word as the user types

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2023

🦋 Changeset detected

Latest commit: 4de8a7d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch
@navikt/aksel Patch
@navikt/aksel-stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@it-vegard it-vegard self-assigned this Aug 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

Storybook demo

Endringer til review: 1

040563ef3 | 59 komponenter | 389 stories

…en-autocompleting-in-combobox

# Conflicts:
#	@navikt/core/react/src/form/combobox/combobox.stories.tsx
#	yarn.lock
…n pressing Enter, instead of using the first FilteredOption
…ests both that we will use "add new" option if available and that we preserve casing for new options
…en-autocompleting-in-combobox

# Conflicts:
#	yarn.lock
@it-vegard it-vegard merged commit f8c12b0 into main Oct 24, 2023
2 checks passed
@it-vegard it-vegard deleted the bugfix/consistent-uppercase-or-lower-case-when-autocompleting-in-combobox branch October 24, 2023 05:50
@github-actions github-actions bot mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Innspill til komponent]: <Combobox />
2 participants