-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Combobox: Mulighet for å begrense hvor mange valg bruker kan ta #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7da5e05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoEndringer til review: 58f14cec5d | 61 komponenter | 402 stories |
…bobox-limit-choices
# Conflicts: # @navikt/core/react/src/form/combobox/FilteredOptions/FilteredOptions.tsx
…of relying on index state. The index state became stale/non-synced when replacing elements in the list.
it-vegard
reviewed
Nov 24, 2023
it-vegard
reviewed
Nov 24, 2023
it-vegard
reviewed
Nov 24, 2023
KenAJoh
reviewed
Jan 25, 2024
@navikt/core/react/src/form/combobox/FilteredOptions/FilteredOptions.tsx
Outdated
Show resolved
Hide resolved
it-vegard
reviewed
Jan 25, 2024
aksel.nav.no/website/pages/eksempler/combobox/with-max-selected-limit.tsx
Outdated
Show resolved
Hide resolved
it-vegard
reviewed
Jan 25, 2024
it-vegard
reviewed
Jan 25, 2024
…en også er sticky
…grunn av manglende Demo-eksport
Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
…ptions.tsx Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
…d-limit.tsx Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
… bottom of the container
… the top of the container
# Conflicts: # yarn.lock
…t introduces a few issues with hovering, etc.
HalvorHaugan
approved these changes
Jan 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I Combobox ønskes det mulighet for å begrense antall valgte valg, f.eks. "velg opptil tre favoritter fra listen".
Figma: https://www.figma.com/file/oy15hc0N3TfkE9Vu5FOyhZ/Combobox?type=design&node-id=0%3A1&mode=dev
Change summary
TODO
aksel.nav.no/website/pages/eksempler
yarn changeset