Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Combobox: Mulighet for å begrense hvor mange valg bruker kan ta #2260

Merged
merged 94 commits into from
Jan 26, 2024

Conversation

larseirikhansen
Copy link
Contributor

@larseirikhansen larseirikhansen commented Sep 7, 2023

Description

I Combobox ønskes det mulighet for å begrense antall valgte valg, f.eks. "velg opptil tre favoritter fra listen".
Figma: https://www.figma.com/file/oy15hc0N3TfkE9Vu5FOyhZ/Combobox?type=design&node-id=0%3A1&mode=dev

Change summary

  • Essentially restructure the whole component

TODO

  • Add/update component-demos for component aksel.nav.no/website/pages/eksempler
  • Run minor yarn changeset

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

🦋 Changeset detected

Latest commit: 7da5e05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/aksel-stylelint Minor
@navikt/aksel Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Storybook demo

Endringer til review: 5

8f14cec5d | 61 komponenter | 402 stories

@larseirikhansen larseirikhansen marked this pull request as ready for review November 23, 2023 14:47
it-vegard and others added 18 commits January 25, 2024 14:34
Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
…ptions.tsx

Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
…d-limit.tsx

Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
…t introduces a few issues with hovering, etc.
@it-vegard it-vegard merged commit 23c472e into main Jan 26, 2024
3 checks passed
@it-vegard it-vegard deleted the combobox-limit-choices branch January 26, 2024 13:24
@github-actions github-actions bot mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants