Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ikoner] Bedre SVG-export #2300

Merged
merged 11 commits into from
Sep 26, 2023
Merged

[Ikoner] Bedre SVG-export #2300

merged 11 commits into from
Sep 26, 2023

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Sep 19, 2023

Description

Resolves #2299

Change summary

  • SVG-export blir nå parset før de blir lagt i /dist

Ikoner: SVG export setter nå height="1em", width="1em" og fill="currentColor".

TODO

  • Må teste at script kjører som forventet på windows. @HalvorHaugan Kunne du ha testet lokalt?

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023

🦋 Changeset detected

Latest commit: 11a6e6a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/aksel-icons Minor
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel Minor
@navikt/aksel-stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023

Storybook demo

fd3e3ddbb | 59 komponenter | 384 stories

@HalvorHaugan
Copy link
Contributor

Ser ut til å funke fint på Windows, men hvorfor parse i stedet for å hardkode endringen?

@KenAJoh
Copy link
Collaborator Author

KenAJoh commented Sep 19, 2023

Ser ut til å funke fint på Windows, men hvorfor parse i stedet for å hardkode endringen?

Ikonene blir automatisk hentet fra Figma med width/height 24 + hardkodet fill-farge. Må endten parses da mellom hentig fra figma -> kode eller fra kode -> dist. Fordelen med å ha 24px + hex-verdi som kilde er at det er lettere å teste at contributors hard laget ikonet riktig.

HalvorHaugan
HalvorHaugan previously approved these changes Sep 19, 2023
@HalvorHaugan HalvorHaugan self-requested a review September 19, 2023 13:30
@HalvorHaugan HalvorHaugan dismissed their stale review September 19, 2023 13:31

Se kommentar

HalvorHaugan
HalvorHaugan previously approved these changes Sep 26, 2023
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
@KenAJoh KenAJoh merged commit d426a94 into main Sep 26, 2023
2 checks passed
@KenAJoh KenAJoh deleted the svg-icons branch September 26, 2023 14:52
@github-actions github-actions bot mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEW] Ikoner: La SVG-import matche output fra React-import
2 participants