Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primitives bleed #2331

Merged
merged 23 commits into from
Sep 27, 2023
Merged

Primitives bleed #2331

merged 23 commits into from
Sep 27, 2023

Conversation

JulianNymark
Copy link
Contributor

🐛

export the Bleed component

@JulianNymark
✨ add Bleed
8a18123
@JulianNymark
🚧 WIP on Bleed
6639529
@JulianNymark
🚧 fix the weirdness of margin-block-end by adding padding
9dde205
@JulianNymark
🚧 wip for bleed calculation of "full"
bb308d1
@JulianNymark
Bleed working "full" horizontal margin
04484e0
@JulianNymark
Merge branch 'main' into primitives-bleed
990834f
@JulianNymark
🚧 wip on reflectivePadding
e8d7e16
@JulianNymark
🚧 wip breakpoints for bleed reflectivePadding
9c3c0ae
@JulianNymark
working reflectivePadding
a327b9a
@JulianNymark
📝 add jsdoc
779990a
@JulianNymark
Merge branch 'main' into primitives-bleed
60820ae
@JulianNymark
♻️ refactor css.ts
25c9faf
@JulianNymark
♻️ refactor style for Bleed
0455d58
@JulianNymark
improve jsdoc, remove unused CSS
45b29bd
@JulianNymark
📝 fix docs for px story
ff69e91
@JulianNymark
✨ add asChild prop
8778a2c
@JulianNymark
📝 add changeset
0c79369
@JulianNymark
📝 add jsdoc
86a85eb
@JulianNymark
♻️ refactor stories
2861f12
@JulianNymark
📝 fix erroneous story text
175e625
@JulianNymark
Merge branch 'main' into primitives-bleed
b8de090
@JulianNymark
export bleed from barrel file
1488f01
@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: f90eb8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

KenAJoh
KenAJoh previously approved these changes Sep 27, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023 •
edited
Loading

Storybook demo

Endringer til review: 5

237016afe | 59 komponenter | 384 stories

@JulianNymark JulianNymark merged commit 98f8729 into main Sep 27, 2023
@JulianNymark JulianNymark deleted the primitives-bleed branch September 27, 2023 13:55
HalvorHaugan
HalvorHaugan reviewed Sep 27, 2023
View reviewed changes
@navikt/core/react/src/layout/bleed/Bleed.stories.tsx
<Box className="p" background="surface-success-subtle">
<Box
padding="3"
className="p"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser ut som dette klassenavnet ikke brukes lenger?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalvorHaugan HalvorHaugan HalvorHaugan left review comments

@KenAJoh KenAJoh KenAJoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JulianNymark @KenAJoh @HalvorHaugan