Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 CopyButton: Justert padding, gap og animasjon #2355

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Conversation

HalvorHaugan
Copy link
Contributor

Closes aksel#295

@HalvorHaugan HalvorHaugan requested a review from KenAJoh October 6, 2023 14:31
@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2023

🦋 Changeset detected

Latest commit: 69e261f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/aksel-stylelint Patch
@navikt/aksel Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Storybook demo

Endringer til review: 6

061a97642 | 59 komponenter | 385 stories

KenAJoh
KenAJoh previously approved these changes Oct 6, 2023
KenAJoh
KenAJoh previously approved these changes Oct 11, 2023
Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tooltip-eksemplet for Aksel.nav.no kan man vurdere om icon bør settes manuelt uten title og med aria-hidden slik at det ikke blir lest opp "kopier kopier fødsesnummer".

@HalvorHaugan HalvorHaugan merged commit 70c5aff into main Oct 11, 2023
3 checks passed
@HalvorHaugan HalvorHaugan deleted the copybtn-231006 branch October 11, 2023 13:36
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants