Add new useVirtualFocus hook, for use in Combobox #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r other components later, but will scope it for Combobox at first.
🦋 Changeset detectedLatest commit: 80b42da The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoEndringer til review: 12a4f8207a0 | 59 komponenter | 390 stories |
…g IDs and for text lookups in lists.
…e of the currently (virtually) focused element instead This allows use of e.g. numbers as options, which data-value didn't.
# Conflicts: # @navikt/core/react/src/form/combobox/FilteredOptions/filteredOptionsContext.tsx # @navikt/core/react/src/form/combobox/Input/Input.tsx # yarn.lock
…g interpreted as being different from the existing options
…ithub.com/navikt/aksel into feature/useVirtualFocus-hook-for-combobox
@navikt/core/react/src/form/combobox/FilteredOptions/filtered-options-util.ts
Outdated
Show resolved
Hide resolved
@navikt/core/react/src/form/combobox/FilteredOptions/filteredOptionsContext.tsx
Outdated
Show resolved
Hide resolved
@navikt/core/react/src/form/combobox/FilteredOptions/filteredOptionsContext.tsx
Outdated
Show resolved
Hide resolved
…ions in a multiselect selectedOptionsContext is not available inside customOptionsContext, so need to take isMultiSelect from props instead
# Conflicts: # yarn.lock
…sulting type mismatches
@navikt/core/react/src/form/combobox/FilteredOptions/filteredOptionsContext.tsx
Outdated
Show resolved
Hide resolved
…xt to reflect that it is now actually a setState-function
…ead of each separate method. Done to remove need to wrap moveFocusUp and moveFocusDown in order to toggle isListOpen
There was a problem hiding this comment.
Liker denne filen, smart å trekke ut utils
larseirikhansen
approved these changes
Nov 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be useful for other components later, but will scope it for Combobox at first.
Description
The useVirtualFocus hook takes in a ref pointing to the container of the elements to use virtual focus on.
E.g. the
ulelement in the dropdown list in Combobox.The hook will maintain the reference to the currently "focused" child element, and provides methods for moving focus up and down by one, jump to the last element or to the top (currently setting the index to -1 to signal virtual focus being removed) or setting virtual focus to a specific element.
The hook also returns the element currently receiving virtual focus. This can then be used to get the ID, for use in e.g.
aria-activeDescendant.Change summary
Added useVirtualHook
PR Checklist TODOs 📝
New component? ✨
Versioning 🏷️
yarn changesetto generate a version-entry for change.