Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Chips.Toggle: Ikon i uvalgt tilstand #2395

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

HalvorHaugan
Copy link
Contributor

Resolves aksel#291

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023

🦋 Changeset detected

Latest commit: f55abe9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/aksel-stylelint Patch
@navikt/aksel Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Storybook demo

Endringer til review: 3

ad7314a26 | 59 komponenter | 386 stories

@@ -20,7 +20,7 @@
cursor: pointer;
align-items: center;
justify-content: center;
gap: var(--a-spacing-1);
gap: var(--a-spacing-05);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.chromatic.com/test?appId=5f801fb2aea7820022de2936&id=652ff042f1aa202996a246cc

Sirkel ser visuelt nærmere ut her enn X ikonet i removable. Bør det være noen px ekstra gap?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Har spilt det inn for Sjur, men ser at denne gap-en gjør at Removable og Toggle tar like stor plass 🤓

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"det skal være litt mindre avstand mellom ikonet og teksten enn ikonet og venstre kant. Også kan det være mange toggles i en gruppe, så hver px teller"

@HalvorHaugan HalvorHaugan merged commit 6d6e644 into main Oct 20, 2023
2 checks passed
@HalvorHaugan HalvorHaugan deleted the toggle-chip-icons branch October 20, 2023 13:54
@github-actions github-actions bot mentioned this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants