-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 Chips.Toggle: Ikon i uvalgt tilstand #2395
Conversation
🦋 Changeset detectedLatest commit: f55abe9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoEndringer til review: 3ad7314a26 | 59 komponenter | 386 stories |
@@ -20,7 +20,7 @@ | |||
cursor: pointer; | |||
align-items: center; | |||
justify-content: center; | |||
gap: var(--a-spacing-1); | |||
gap: var(--a-spacing-05); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.chromatic.com/test?appId=5f801fb2aea7820022de2936&id=652ff042f1aa202996a246cc
Sirkel ser visuelt nærmere ut her enn X ikonet i removable. Bør det være noen px ekstra gap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Har spilt det inn for Sjur, men ser at denne gap-en gjør at Removable og Toggle tar like stor plass 🤓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"det skal være litt mindre avstand mellom ikonet og teksten enn ikonet og venstre kant. Også kan det være mange toggles i en gruppe, så hver px teller"
Resolves aksel#291