-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Datepicker/Modal] Datepicker bruker nå Modal på mobil og for nested Modal #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 20d8032 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoEndringer til review: 16480091c5b | 59 komponenter | 389 stories |
HalvorHaugan
requested changes
Oct 31, 2023
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
HalvorHaugan
previously approved these changes
Nov 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
780px
DateWrapper
-komponent (for internt bruk)openOnFocus
-prop da man bare kan åpne Popover/Modal ved klikk på knapponClose
fra Popover/Modal for lukking ved outside-click eller ESC. Fjernet dauseEscape
oguseOutsideClick
useMedia
-hook som lytter på mediaqueries (for å bytte mellom Popover og Modal on-the-fly)Fjernet også
bubbleEscape
-prop fra Popover og Datepicker da denne ikke trengs lengre. Ser ut som ingen bruker den https://github.com/search?type=code&q=org%3Anavikt+bubbleEscape, så trenger ikke majorTesting
JSDOM (jest) støtter ikke
matchMedia
. Det finnes polyfills for dette, men ser caniuse-støtten er høyere en de fleste andre features:Tenker da det er unødvendig med polyfill, å returnerer heller en default-value i
useMedia.tsx
og kjører ikkematchMedia
.Testene fungerer da i jest + brukere trenger ikke lage egen mock for
matchMedia
og fallbacker til popover som var brukt tidligere. Trenger da heller ikke være redd for at noen av testene til brukere feiler på minor-update