-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏷️ fix types for modal issue #2744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1e757f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demof5faa4f40 | 57 komponenter | 221 stories |
KenAJoh
previously approved these changes
Feb 21, 2024
KenAJoh
approved these changes
Feb 21, 2024
Merged
JulianNymark
added a commit
that referenced
this pull request
Feb 26, 2024
* 🏷️ fix types for modal issue * liten style justering * Tester! * changeset * tester test * tester test 2 * tester test 3 * Revert experiments, add proper tests * fix Portal.stories.tsx * 🏷️ Endret rekkefølge på modal conditional-typer for bedre feilmelding * revert rekkefølge * testkode --------- Co-authored-by: Halvor Haugan <halvor.haugan@nav.no> Co-authored-by: Ken <ken.aleksander@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix modal typing issues
should solve the following: