Fixed Combobox small sizing #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… make the small variant the same size as TextField and so on.
🦋 Changeset detectedLatest commit: 99eddd1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoEndringer til review: 50ffcd8697 | 82 komponenter | 183 stories |
|
Ser ut som litt av øverste valg "banana" legger seg litt under "2 av 2 er valgt" alert nå |
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
Removed pointer-events: none, because I couldn't find a use-case for it. The reason vanished when we squashed commits.
…d by the "max selected" message
…so we need a selector for each SVG we want to set size for.
…nment checkmarks.
HalvorHaugan
reviewed
May 7, 2024
HalvorHaugan
previously approved these changes
May 29, 2024
HalvorHaugan
approved these changes
May 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove extra vertical padding and fixed height for combobox input, to make the small variant the same size as TextField
Ref. Slack discussion: https://nav-it.slack.com/archives/C7NE7A8UF/p1709640219782299
New heights are 32px for small and 48px for medium/default
Change summary