Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/template intropage #2876

Merged
merged 56 commits into from
May 21, 2024
Merged

Feature/template intropage #2876

merged 56 commits into from
May 21, 2024

Conversation

it-vegard
Copy link
Contributor

Description

A template for Form IntroPage

Change summary

  • added a template for IntroPage for forms, for both Storybooks

PR Checklist 📝 (Remove fields after check!)

New component? ✨

  • Check that component-styling is correctly configured in @navikt/core/css/config/_mappings.js. This is needed for correct build and CDN upload.
  • Check that styling is correctly exported from @navikt/core/css/index.css
  • Check that correct tokens for component is documented in @navikt/core/css/tokens.json
  • Check that only needed components and types are exported from @navikt/core/react/src/index.ts
  • Add JSDoc to component (see other components for reference)
  • Create storybook-stories for relevant component variations and compositions. Stories are used for visual regression testing, so make sure they are complete.
  • Is the component sufficiently complex to warrant tests? Add some unit-tests for vitest.

Component-updates 🎉

  • Revalidate if everything under New component is still accounted for
  • Deprecating/removing a CSS class? Add it to @navikt/aksel-stylelint/src/deprecations.ts with a suitable description. This helps stylelint-users keep their code clean and bug-free.

Documentation 📝

  • Add/update component-demos for component aksel.nav.no/website/pages/eksempler
  • Create/Update documentation in sanity if needed
    Note: Props, tokens and examples only updates to sanity on merge to main

Versioning 🏷️

  • Run yarn changeset to generate a version-entry for change.
    • Bug/hotfix: Patch
    • New feature: Minor
    • Breaking change: Major
  • Adding breaking changes? Consider adding a codemod for easier migration.
  • Breaking changes also needs documentation under "Migration"-page on website

Copy link

changeset-bot bot commented Apr 23, 2024

🦋 Changeset detected

Latest commit: 9f4d374

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-css Patch
@navikt/ds-react Patch
@navikt/aksel-stylelint Patch
@navikt/aksel Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 23, 2024

Storybook demo

94b5781bd | 64 komponenter | 165 stories

aksel.nav.no/website/components/assets/Icons.tsx Outdated Show resolved Hide resolved
aksel.nav.no/website/components/assets/Icons.tsx Outdated Show resolved Hide resolved
</Page.Block>
<Page.Block width="text">
<VStack gap="12">
<GuidePanel poster>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ikke lagt merke til tidligere, men skjermelsere leser opp "NAV veileder illustrasjon" når de møter på guidepanel. Bør illustrasjonen være aria-hidden? (Trengs ikke fikses i denne PR-en hvis det ikke er en åpenbar forbedring)

</List>
</Box>
<Box>
<Accordion>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accordion leser opp "vis mer" før tittel hver gang på grunn av chevron. Bør denne også skjules? Skjermlesere får opp "expandable button" og "collapses/expanded" uansett 🤔 (Trengs ikke fikses i denne PR-en hvis det ikke er en åpenbar forbedring)

…ger title does not take space from pictogram
it-vegard added 2 commits May 15, 2024 10:34
…e copied. Maybe we should extract the form header as a component in Aksel?
@it-vegard it-vegard marked this pull request as ready for review May 15, 2024 09:42
it-vegard and others added 3 commits May 15, 2024 12:50
…d-alternativ-soknad.tsx

Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
…nsjon/soknad-introside-alderspensjon.tsx

Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
@it-vegard it-vegard merged commit 62dd6a3 into main May 21, 2024
3 checks passed
@it-vegard it-vegard deleted the feature/template-intropage branch May 21, 2024 14:02
@github-actions github-actions bot mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants