-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/template intropage #2876
Conversation
…rest will follow. Needs to move icon in header outside main column.
…or more of these sections.
…bile/on the left on desktop
…ke it available for demo tomorrow. Needs to find another place.
🦋 Changeset detectedLatest commit: 9f4d374 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demo94b5781bd | 64 komponenter | 165 stories |
# Conflicts: # yarn.lock
… some TS-error later.
aksel.nav.no/website/pages/templates/soknad-introside-aap/soknad-introside-aap.tsx
Show resolved
Hide resolved
aksel.nav.no/website/pages/templates/soknad-introside-aap/soknad-introside-aap.tsx
Outdated
Show resolved
Hide resolved
aksel.nav.no/website/pages/templates/soknad-introside-aap/soknad-introside-aap.tsx
Outdated
Show resolved
Hide resolved
aksel.nav.no/website/pages/templates/soknad-introside-aap/soknad-introside-aap.tsx
Outdated
Show resolved
Hide resolved
aksel.nav.no/website/pages/templates/soknad-introside/intro-med-alternativ-soknad.tsx
Outdated
Show resolved
Hide resolved
aksel.nav.no/website/pages/templates/soknad-introside-aap/soknad-introside-aap.tsx
Outdated
Show resolved
Hide resolved
</Page.Block> | ||
<Page.Block width="text"> | ||
<VStack gap="12"> | ||
<GuidePanel poster> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ikke lagt merke til tidligere, men skjermelsere leser opp "NAV veileder illustrasjon" når de møter på guidepanel. Bør illustrasjonen være aria-hidden
? (Trengs ikke fikses i denne PR-en hvis det ikke er en åpenbar forbedring)
</List> | ||
</Box> | ||
<Box> | ||
<Accordion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accordion leser opp "vis mer" før tittel hver gang på grunn av chevron. Bør denne også skjules? Skjermlesere får opp "expandable button" og "collapses/expanded" uansett 🤔 (Trengs ikke fikses i denne PR-en hvis det ikke er en åpenbar forbedring)
…ger title does not take space from pictogram
…y won't be included in the example code.
…e copied. Maybe we should extract the form header as a component in Aksel?
aksel.nav.no/website/pages/templates/soknad-introside-aap/soknad-introside-aap.tsx
Outdated
Show resolved
Hide resolved
aksel.nav.no/website/pages/templates/soknad-introside/intro-med-alternativ-soknad.tsx
Outdated
Show resolved
Hide resolved
aksel.nav.no/website/pages/templates/soknad-introside/intro-med-alert.tsx
Outdated
Show resolved
Hide resolved
…d-alternativ-soknad.tsx Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
...no/website/pages/templates/soknad-introside-alderspensjon/soknad-introside-alderspensjon.tsx
Outdated
Show resolved
Hide resolved
aksel.nav.no/website/pages/templates/soknad-introside-aap/soknad-introside-aap.tsx
Outdated
Show resolved
Hide resolved
…nsjon/soknad-introside-alderspensjon.tsx Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
...no/website/pages/templates/soknad-introside-alderspensjon/soknad-introside-alderspensjon.tsx
Outdated
Show resolved
Hide resolved
aksel.nav.no/website/pages/templates/soknad-introside-aap/soknad-introside-aap.tsx
Outdated
Show resolved
Hide resolved
aksel.nav.no/website/pages/templates/soknad-introside/intro.tsx
Outdated
Show resolved
Hide resolved
aksel.nav.no/website/pages/templates/soknad-introside-aap/soknad-introside-aap.tsx
Show resolved
Hide resolved
aksel.nav.no/website/pages/templates/soknad-introside/intro-med-alternativ-soknad.tsx
Outdated
Show resolved
Hide resolved
…it has aria-hidden set
…sed, and use 0-index on all form intropage examples
Description
A template for Form IntroPage
Change summary
PR Checklist 📝 (Remove fields after check!)
New component? ✨
@navikt/core/css/config/_mappings.js
. This is needed for correct build and CDN upload.@navikt/core/css/index.css
@navikt/core/css/tokens.json
@navikt/core/react/src/index.ts
Component-updates 🎉
New component
is still accounted for@navikt/aksel-stylelint/src/deprecations.ts
with a suitable description. This helps stylelint-users keep their code clean and bug-free.Documentation 📝
aksel.nav.no/website/pages/eksempler
Note: Props, tokens and examples only updates to sanity on merge to main
Versioning 🏷️
yarn changeset
to generate a version-entry for change.