Combobox: Pressing Escape in while focusing a Combobox inside a Modal will close the Modal #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llow the keydown event, so it does not close a Modal
🦋 Changeset detectedLatest commit: fb19ffb The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demod38ccbede | 87 komponenter | 133 stories |
|
I think we can live without a test, but would be nice with a story. |
it-vegard
changed the title
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
…e a value (which will be cleared). Also co-located all the Escape-handling in keyDown. This also better mimics Select's native behaviour.
HalvorHaugan
reviewed
Aug 2, 2024
…ng. La inn en tekst for å forklare caset.
HalvorHaugan
previously approved these changes
Aug 2, 2024
…ombobox-with-escape # Conflicts: # @navikt/core/react/src/form/combobox/Input/Input.tsx # @navikt/core/react/src/form/combobox/combobox.stories.tsx
HalvorHaugan
approved these changes
Aug 2, 2024
it-vegard
deleted the
bugfix/stop-closing-modal-too-when-closing-combobox-with-escape
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If pressing Escape in a Combobox inside of a Modal, the Modal would close.
Combobox should instead swallow the keydown event, so it does not close the Modal.
NB! This fix only swallows the event if FilteredOptions is open.
Fixes #3052
Change summary
Suppress keydown event when pressing Escape key while Combobox.FilteredOptions is open
For discussion:
I don't have any tests yet, because I couldn't get them to fail pre-fix.
Turns out Storybook/Testing Library
userEvent.keyboard("{Escape}")does not cause the Modal to close, while doing the same manually (even in Storybook) will cause the error. Found references to the same here, and a potential fix here, but then the fix wouldn't work in the test (but it worked in real-life).Do we need tests for this?