Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: Added scroll shadows #3083

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Modal: Added scroll shadows #3083

merged 3 commits into from
Aug 12, 2024

Conversation

HalvorHaugan
Copy link
Contributor

@HalvorHaugan HalvorHaugan commented Aug 9, 2024

Closes #3060

Copy link

changeset-bot bot commented Aug 9, 2024

🦋 Changeset detected

Latest commit: 86d9c50

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-css Patch
@navikt/aksel-stylelint Patch
@navikt/aksel Patch
@navikt/ds-react Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 9, 2024

Storybook demo

Endringer til review: 6

da9f2339d | 88 komponenter | 139 stories

Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the implementation with background-attachment: local, local, scroll, scroll; 🤩

@navikt/core/css/modal.css Outdated Show resolved Hide resolved
@HalvorHaugan
Copy link
Contributor Author

Love the implementation with background-attachment: local, local, scroll, scroll; 🤩

Not my idea, but quite elegant 😄

@HalvorHaugan HalvorHaugan marked this pull request as ready for review August 12, 2024 10:26
@HalvorHaugan HalvorHaugan merged commit c53543c into main Aug 12, 2024
4 checks passed
@HalvorHaugan HalvorHaugan deleted the modal-scrollshadow branch August 12, 2024 10:38
@github-actions github-actions bot mentioned this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Innspill til komponent]: Modal. Indikasjon på at det er mer innhold når container blir scrollable
2 participants