Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darkside] Combobox: add scroll-margin #3397

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[Darkside] Combobox: add scroll-margin #3397

merged 1 commit into from
Nov 22, 2024

Conversation

HalvorHaugan
Copy link
Contributor

We need scroll-margin since the focus outline is outside the item.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: 2301622

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Storybook demo

2101d7bf9 | 91 komponenter | 135 stories

@HalvorHaugan HalvorHaugan merged commit e257bf4 into main Nov 22, 2024
4 checks passed
@HalvorHaugan HalvorHaugan deleted the combobox-darkside-scrollmargin branch November 22, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenAJoh KenAJoh KenAJoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HalvorHaugan @KenAJoh