Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add JSDoc with default values to nb.ts #3479

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Conversation

HalvorHaugan
Copy link
Contributor

Adds JSDoc with values right before build, like this:

  Alert: {
    /** @default "Lukk varsel" */
    closeAlert: "Lukk varsel",
    /** @default "Lukk melding" */
    closeMessage: "Lukk melding",
    /** @default "Feil" */
    error: "Feil",
    /** @default "Informasjon" */
    info: "Informasjon",
    /** @default "Suksess" */
    success: "Suksess",
    /** @default "Advarsel" */
    warning: "Advarsel",
  },

Reverts it afterwards so that we don't need to commit it.

Copy link

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Latest commit: f88d7e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 20, 2024

Storybook demo / Chromatic

5f4491200 | 91 components | 135 stories

Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jscodeshift is not currently a devDependency of "core/react/package.json", everything else looks good 🚀

KenAJoh
KenAJoh previously approved these changes Dec 23, 2024
@KenAJoh KenAJoh merged commit 137b4c4 into main Dec 23, 2024
3 checks passed
@KenAJoh KenAJoh deleted the auto-jsdoc-i18n branch December 23, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants