Forenkling og avgrensning i BrevsignaturService ifm utledning av "skjulSaksbehandler"-flagget #2773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
throndi
requested review from
charliemidtlyng,
ViktorGSolberg,
olekvernberg,
ma10s,
gunnsteingarmo,
EndreHM and
krikof-nav
src/main/kotlin/no/nav/familie/ef/sak/brev/FrittståendeBrevService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/no/nav/familie/ef/sak/brev/BrevsignaturService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/no/nav/familie/ef/sak/brev/BrevsignaturService.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+107
to
+108
| assertThat(vedtaksbrevSlot.captured.besluttersignatur).isNotEmpty() | ||
| assertThat(vedtaksbrevSlot.captured.enhet).isNotEmpty() |
There was a problem hiding this comment.
Basert på testens navn så høres det ut som disse SKAL være tomme, eller? Hva setter vi på enhet og besluttersignatur dersom vedtakErUtenBeslutter..?
There was a problem hiding this comment.
testen heter "skal fortsatt sette saksbehandler og enhet hvis vedtakErUtenBeslutter er true" ?
There was a problem hiding this comment.
presiserte teksten med "besluttersignatur" i stedet for "saksbehandler".
There was a problem hiding this comment.
hvis man ikke har en egen beslutter, så blir vel saksbehandler satt som beslutter, men det skal jo ikke vises hvis man skal skjule beslutter. Kan jo lage en tom streng som før evt.
…nto skjulBeslutterSignaturBoolean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hvorfor er denne endringen nødvendig? ✨
Utledning av skjulSaksbehandler har vært litt diffus, og har ført til at man kan sette dette flagget litt som man vil. Dette kom tydeligere frem når man endret rekkefølgen på signaturene.
Lager derfor et utkast til et par forenklinger i BrevsignaturService. Endrer for øvrig så lite som mulig.
Relatert favro: https://favro.com/organization/98c34fb974ce445eac854de0/a64c6aad9b0d61ef6c0290bd?card=NAV-24032