Lagt til retry med delay på reader for å minske antall alarmer når sidecaren går ned før appen #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…decaren går ned før appen
thoalm
reviewed
Feb 20, 2025
| val electorPath = Environment.hentLeaderSystemEnv() ?: return null | ||
| fun isLeader( | ||
| antallGanger: Int = 3, | ||
| forsinkelseIms: Long = 1000, |
There was a problem hiding this comment.
Kan vurdere å sende inn en variabel av type Duration da Thread.sleep()også godtar det
Suggested change
| forsinkelseIms: Long = 1000, | |
| forsinkelse: Duration = Duration.ofMillis(1000), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NAV-23684
Lagt til en retry med delay på isLeader. Ser at sidecaren for leader går ned før appen ved redeploy. Muligens at en retry med delay på maks 3s ikke er nok, men samtidig ønsker man ikke for treg isLeader før den feiler.
Hvis ikke 3s er nok så tenker jeg man kan fjerne error-loggingen. Siden tjenesten vil returnerer null hvis leader er nede.
Også byttet til den oppdaterte ENV-verdien man skal bruke, siden ELECTOR_PATH er gammel måte.