Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ta i bruk esm import nå som det er fikset i winston #264

Merged
merged 1 commit into from
Feb 2, 2022
Merged

ta i bruk esm import nå som det er fikset i winston #264

merged 1 commit into from
Feb 2, 2022

Conversation

kenglxn
Copy link
Contributor

@kenglxn kenglxn commented Feb 1, 2022

i tillegg:

  • fjernet --experimental-modules flagget siden Dockerfile nå kjører med node:16
  • bumpet prom api og client pga deprecation warning:
(node:22932) [DEP0152] DeprecationWarning: Custom PerformanceEntry accessors are deprecated. Please use the detail property.
    at PerformanceObserver.<anonymous> (/Users/g161400/dev/git/ditt-nav-arbeidsgiver/server/node_modules/prom-client/lib/metrics/gc.js:42:38)

re:

@kenglxn
ta i bruk esm import nå som det er fikset i winston
068e6cd 
i tillegg:
- fjernet --experimental-modules flagget siden Dockerfile nå kjører med node:16
- bumpet prom api og client pga deprecation warning:
```
(node:22932) [DEP0152] DeprecationWarning: Custom PerformanceEntry accessors are deprecated. Please use the detail property.
    at PerformanceObserver.<anonymous> (/Users/g161400/dev/git/ditt-nav-arbeidsgiver/server/node_modules/prom-client/lib/metrics/gc.js:42:38)
```

re:
- https://github.com/winstonjs/winston/releases/tag/v3.4.0
- winstonjs/winston#2006
@kenglxn kenglxn requested a review from a team as a code owner February 1, 2022 07:57
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kenglxn kenglxn merged commit f4dbe8d into master Feb 2, 2022
@kenglxn kenglxn deleted the winston_esm_import branch February 2, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbb peterbb peterbb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenglxn @peterbb