Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PORT environment variable #200

Closed
bethesque opened this issue Feb 20, 2022 · 5 comments · Fixed by #203
Closed

Support PORT environment variable #200

bethesque opened this issue Feb 20, 2022 · 5 comments · Fixed by #203
Labels
enhancement New feature or request

Comments

@bethesque
Copy link
Contributor

Thanks for your work on this server! It has been very useful to our project.

I'd love to be able to run your mock server on Heroku. To do this, it needs to be able to honour the PORT environment variable. I've tried building my own docker image that extends your image and maps the PORT to SERVER_PORT, but it doesn't seem there's a shell environment installed on the image, and I can't find your source Dockerfile. Is this something you'd consider supporting? I would be happy to do a PR, but as mentioned, I can't find the source.

@ybelMekk
Copy link
Contributor

ybelMekk commented Feb 21, 2022

Hi. I’m happy to hear that you find the server useful. We would love to have a PR! And the source file, yes, I need to reach out to my docker magician @jksolbakken you’ve been involved dealing with this right? 😅

May be this is this an alternative? https://github.com/navikt/mock-oauth2-server/#docker

@ybelMekk ybelMekk added the enhancement New feature or request label Feb 21, 2022
@bethesque
Copy link
Contributor Author

Ah, maybe there's some magic in the jibDockerBuild task that doesn't need a Dockerfile. I am totally not a JVM person, just relying on my ability to modify an existing build! I've got it running in my fork

You might want to add pull_request to the on: for the tests?

@ybelMekk
Copy link
Contributor

@bethesque It is already there for PR´s 👍🏾

@bethesque
Copy link
Contributor Author

Ah, I see, you've got a separate one for PRs 👍🏽

@ybelMekk ybelMekk linked a pull request Feb 23, 2022 that will close this issue
@ybelMekk
Copy link
Contributor

@tronghn @tommytroen or @jksolbakken any comments on the PR? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants