Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support refreshtoken (as JWT) from keycloak #242

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

tommytroen
Copy link
Collaborator

Fixes #210

  • Ensures minimal compatibility with keycloak js client which expects the refresh token to be parseable JWT.
  • Creates the refresh token as a Plain JWT (i.e. unsigned) containing nonce and jti if nonce is present in auth request

@tommytroen tommytroen added the enhancement New feature or request label Apr 22, 2022
@tommytroen tommytroen requested a review from a team as a code owner April 22, 2022 11:00
@tommytroen
Copy link
Collaborator Author

@jp7677 I have created a PR for #210. Went for the semi-hacky solution :) Can you verify on your end that keycloak client works as intended?

@jp7677
Copy link
Contributor

jp7677 commented Apr 26, 2022

Hi @tommytroen thanks a lot for continuing with my suggestion and turning it into a less hacky solution :)
I just tested your branch here and it works perfectly, so LGTM!

@ybelMekk
Copy link
Contributor

🚢 ?

@tommytroen tommytroen merged commit 5484d34 into master Apr 27, 2022
@tommytroen tommytroen deleted the support_refreshtoken_from_keycloak branch April 27, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyclock-js client library expects refresh tokens being a JWT
3 participants