Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: example of how we can document the api #270

Merged
merged 7 commits into from
Jun 15, 2022
Merged

Conversation

ybelMekk
Copy link
Contributor

@ybelMekk ybelMekk commented Jun 3, 2022

with dokka and kdoc and GitHub flavored markdown (gfm)

This can be done with HTML format also if preferred.

The action runs on publish and updates doc folder to contain the latest release documentation updates.

Also changed all workflows with gradle cache setup, to use action setup-java built-in cache instead of separate action.

Please add documentation before approve/merge, as this is lacking for the library due to some developer laziness 😄

Also, checkout the branch, and run ./gradlew dokkaHtm or ./gradlew dokkaGtm to explore the result.

…itHub flavored markdown (gfm)

This can be done with HTML format also if preferred.

The action runs on publish and updates doc folder to contain the latest release documentation updates.

Also changed all workflows with gradle cache setup, to use action `setup-java` built-in cache instead of separate action.

Please add documentation before approve/merge, as this is lacking for the library due to some developer `laziness` 😄
@ybelMekk ybelMekk requested a review from a team as a code owner June 3, 2022 07:02
@ybelMekk ybelMekk linked an issue Jun 3, 2022 that may be closed by this pull request
@tronghn
Copy link
Contributor

tronghn commented Jun 3, 2022

Looks good to me.

Dokka also appears to have a dokkaJavadoc task as well - does this run as part of the publish task? We should probably consider setting up a javadoc so that releases to Maven Central also includes the documentation.

@ybelMekk
Copy link
Contributor Author

ybelMekk commented Jun 3, 2022

Looks good to me.

Dokka also appears to have a dokkaJavadoc task as well - does this run as part of the publish task? We should probably consider setting up a javadoc so that releases to Maven Central also includes the documentation.

good as @tronghn . Sounds like a better solution, if we go for release of documentation.

@tronghn
Copy link
Contributor

tronghn commented Jun 3, 2022

I mean, we can have both solutions - they both stem from the same source anyway 😄

@ybelMekk
Copy link
Contributor Author

ybelMekk commented Jun 3, 2022

🤩

@ybelMekk
Copy link
Contributor Author

ybelMekk commented Jun 3, 2022

@tronghn please add sum commits, if you have a good one?

@ybelMekk
Copy link
Contributor Author

seems like a good start to me, if we want to include this? @tommytroen , @jksolbakken @tronghn ?

@ybelMekk ybelMekk merged commit be098f7 into master Jun 15, 2022
@ybelMekk ybelMekk deleted the add-dokka-and-kdoc branch June 15, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: Add KDoc and dokka
3 participants