feat: support custom TimeProvider when validating tokens (introspect, userinfo) #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommytroen
force-pushed
the
feat_verify_with_timeprovider
branch
from
540b611
to
36ca7a8
Compare
* add verify function to OAuth2TokenProvider and use the TimeProvider if set - i.e. via overriding Nimbus DefaultJWTClaimsVerifier's currentTime function * refactor tests for simplicity
tommytroen
force-pushed
the
feat_verify_with_timeprovider
branch
from
36ca7a8
to
7a0a8e1
Compare
* necessary to use jwkSelector to only get keys for supported algorithm * use Instant.now for currentTime when TimeProvider not set * formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only verify tokens issued from the server in the UserInfo and Introspection endpoints (other endpoints simply use the token as is without verification). This should fix #700 by using new verify function from the
OAuth2TokenProviderclass.