[KAIZEN-0] tvinger core-js til versjon 3.5.0 #1279
Merged
+22
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gjøres pga følgende issues; JakeChampion/fetch#750 JakeChampion/fetch#748 zloirock/core-js#751 zloirock/core-js#741 I bunn og grunn, core-js@^3.6.0 introduserte støtte for String.prototype.split med regex som har sticky-flag. Pga bug her så fungerer ikke funksjonen som forventet noe mer i eldre IE11 versjoner. E.g `"test".split(/e/) === ['t', 'e', 's', 't']`, denne burde gitt `['t', 'st']`
olofab
reviewed
Jun 9, 2020
| import { configure } from 'enzyme'; | ||
| import EnzymeReactAdapter from 'enzyme-adapter-react-16'; | ||
| import 'jest-enzyme'; | ||
| import 'babel-polyfill'; |
There was a problem hiding this comment.
Så babel gjorde split.regex biten før? Nå går alt via core-js?
There was a problem hiding this comment.
Dette er bare for test-biten, her ble babel-polyfill brukt slik at Array.prototype.flatMap etc skulle eksistere under test.
Men babel-polyfill har blitt deprecated til fordel for core-js, så bytter derfor om på det i test-sammenheng også.
There was a problem hiding this comment.
Aha. Da skjønner jeg! Derfor fetch-mock også forsvinner?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gjøres pga følgende issues;
JakeChampion/fetch#750
JakeChampion/fetch#748
zloirock/core-js#751
zloirock/core-js#741
I bunn og grunn, core-js@^3.6.0 introduserte støtte for
String.prototype.split med regex som har sticky-flag. Pga bug her så
fungerer ikke funksjonen som forventet noe mer i eldre IE11 versjoner.
E.g
"test".split(/e/) === ['t', 'e', 's', 't'], denne burde gitt['t', 'st']