-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:various:fix compiler warnings #940
Conversation
on my setup navit_core build without non avoidable warnings.
A pity CodeFactor doesn't help here. This would be really helpful. |
The current CodeFactor "findings" are a good example why CodeFactor should not be blocking. The duplicated code is the plug ins. As those are built and linked separately, one cannot just "unify" the code. I think here the code was duplicated for good reasons. If anybody starts up a new plug in he will likely start by copying one of the existing ones. And most likely nobody wants to mess up the old one by trying to unify code. It's good CodeFactor tells this, but it's also good the developer can decide to ignore it or not. Last but not least as the PR has nothing and really nothing to do with fixing such things.
|
Codefactor is not blocking. The only one that is blocking is circleci ("build_all" which is the target for all the circleci builds) and you can see it as it says "Required" next to details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty impressive cleanup! Thanks for doing that.
I think I understood most of the changes. A 2nd pair of eyes on this are welcome tho.
Yes luckily CodeFactor is not blocking anymore. But as there is another round of discussions going on in some PRs I do not refer from here, I left the comment to point out why CodeFactor shouldn't be blocking. Its a good tool but far away from being fool prove. |
* fix:core:build without warnings on my setup navit_core build without non avoidable warnings. * fix:dbus:fix compiler warnings * fix:gui/internal: remov compiler warnings * fix:various:remove compiler warnings * fix:various remove compiler warnings. * fix:various: fix android compiler warnings
* fix:core:build without warnings on my setup navit_core build without non avoidable warnings. * fix:dbus:fix compiler warnings * fix:gui/internal: remov compiler warnings * fix:various:remove compiler warnings * fix:various remove compiler warnings. * fix:various: fix android compiler warnings
This PR fixes a lot of compiler warnings. The core and the well maintained plug ins build at least under Linux without severe warnings.