Skip to content

Switch "Extension Actions" with "Session Actions" and change order of actions in Extension actions #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
inson1 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Switch "Extension Actions" with "Session Actions" and change order of actions in Extension actions #107

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
576ac30
done
inson1 Nov 14, 2023
186f343
Merge branch 'main' into Switch-Extension-Actions-with-Session-Actions
inson1 Nov 26, 2023
eb8f1b7
Update General.svelte
inson1 Nov 26, 2023
7344c7a
Update General.svelte
inson1 Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 31 additions & 31 deletions src/lib/components/options/pages/General.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,37 +84,6 @@
</label>
</Section>

<Section title={i18n.getMessage('settingsExtensionActionsHeading')}>
<label class="flex flex-col gap-2 font-medium">
{i18n.getMessage('settingsURLFilterList')}
<textarea
name="filter-list"
id="filter-list"
rows="8"
placeholder={i18n.getMessage('settingsURLFilterListPlaceholder')}
class="resize-none rounded-md bg-neutral-3 p-2 text-sm placeholder:text-neutral-content/40"
inputmode="url"
value={urlList}
on:change={(ev) => handleFilterListChange(ev, urlList)}
/>
</label>

<Switch
title={i18n.getMessage('settingsLazyload')}
description={i18n.getMessage('settingsLazyloadDescription')}
checked={$settings.discarded}
on:change={() => settings.changeSetting('discarded', !$settings.discarded)}
/>

<button
type="button"
class="max-w-fit rounded-md bg-error px-4 py-2 text-white hover:bg-error-focus"
on:click={settings.clear}
>
{i18n.getMessage('settingsResetAll')}
</button>
</Section>

<Section title={i18n.getMessage('settingsSessionActionsHeading')}>
<Switch
title={i18n.getMessage('settingsDoNotAskForSessionName')}
Expand Down Expand Up @@ -153,3 +122,34 @@
>
</div>
</Section>

<Section title={i18n.getMessage('settingsExtensionActionsHeading')}>
<Switch
title={i18n.getMessage('settingsLazyload')}
description={i18n.getMessage('settingsLazyloadDescription')}
checked={$settings.discarded}
on:change={() => settings.changeSetting('discarded', !$settings.discarded)}
/>

<label class="flex flex-col gap-2 font-medium">
{i18n.getMessage('settingsURLFilterList')}
<textarea
name="filter-list"
id="filter-list"
rows="8"
placeholder={i18n.getMessage('settingsURLFilterListPlaceholder')}
class="resize-none rounded-md bg-neutral-3 p-2 text-sm placeholder:text-neutral-content/40"
inputmode="url"
value={urlList}
on:change={(ev) => handleFilterListChange(ev, urlList)}
/>
</label>

<button
type="button"
class="max-w-fit rounded-md bg-error px-4 py-2 text-white hover:bg-error-focus"
on:click={settings.clear}
>
{i18n.getMessage('settingsResetAll')}
</button>
</Section>