Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve trailing semicolon if followed by comment #571

Conversation

MarcoGorelli
Copy link
Collaborator

closes #532

work in progress

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2021

Codecov Report

Merging #571 (e50dd16) into master (9deb348) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #571   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          758       781   +23     
  Branches       110       115    +5     
=========================================
+ Hits           758       781   +23     
Impacted Files Coverage Δ
nbqa/replace_source.py 100.00% <100.00%> (ø)
nbqa/save_source.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9deb348...e50dd16. Read the comment docs.

@MarcoGorelli MarcoGorelli requested a review from a team April 17, 2021 11:56
@MarcoGorelli
Copy link
Collaborator Author

still need to get rid of the

            result.append(re.sub(r";(\s*)$", "\\1", parsed_cell))

line

@MarcoGorelli MarcoGorelli marked this pull request as draft April 17, 2021 13:07
@MarcoGorelli MarcoGorelli removed the request for review from a team April 17, 2021 14:59
…ithub.com:MarcoGorelli/nbQA into preserve-trailingsemicolon-if-followed-by-comment
@MarcoGorelli MarcoGorelli marked this pull request as ready for review April 17, 2021 15:26
@MarcoGorelli MarcoGorelli merged commit 1c57a52 into nbQA-dev:master Apr 18, 2021
@MarcoGorelli MarcoGorelli deleted the preserve-trailingsemicolon-if-followed-by-comment branch April 18, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we use ast.parse / tokenize for trailing semicolons / comments?
2 participants