-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preserve trailing semicolon if followed by comment #571
Merged
MarcoGorelli
merged 7 commits into
nbQA-dev:master
from
MarcoGorelli:preserve-trailingsemicolon-if-followed-by-comment
Apr 18, 2021
Merged
preserve trailing semicolon if followed by comment #571
MarcoGorelli
merged 7 commits into
nbQA-dev:master
from
MarcoGorelli:preserve-trailingsemicolon-if-followed-by-comment
Apr 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 758 781 +23
Branches 110 115 +5
=========================================
+ Hits 758 781 +23
Continue to review full report at Codecov.
|
MarcoGorelli
commented
Apr 17, 2021
MarcoGorelli
commented
Apr 17, 2021
MarcoGorelli
commented
Apr 17, 2021
MarcoGorelli
commented
Apr 17, 2021
still need to get rid of the result.append(re.sub(r";(\s*)$", "\\1", parsed_cell)) line |
…ithub.com:MarcoGorelli/nbQA into preserve-trailingsemicolon-if-followed-by-comment
MarcoGorelli
deleted the
preserve-trailingsemicolon-if-followed-by-comment
branch
April 18, 2021 17:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #532
work in progress