Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Black version to 22.3.0 #717

Closed
wants to merge 1 commit into from

Conversation

chamilad
Copy link

@chamilad chamilad commented Apr 4, 2022

This change updates the precommit config to have the latest Black
version (at the time of this commit). The main reason for doing so is to
get the latest fixes for a bug caused in a dependency library, click.
More details about this can be found at
psf/black#2964

This resolves #716

This change updates the precommit config to have the latest Black
version (at the time of this commit). The main reason for doing so is to
get the latest fixes for a bug caused in a dependency library, click.
More details about this can be found at
psf/black#2964
@chamilad
Copy link
Author

chamilad commented Apr 4, 2022

pylint.org was down when this ran, but they seems to have added a redirect to pylint.pyqca.. Should be good if the workflow is run again.

@MarcoGorelli
Copy link
Collaborator

Thanks @chamilad

Closing as the solution is to pin black in additional_dependencies

@chamilad chamilad closed this Apr 6, 2022
@s-weigand
Copy link
Contributor

Thanks @chamilad

Closing as the solution is to pin black in additional_dependencies

While this does not fix #716 , it fixes that pre-commit is broken when you don't have a cached env for black with click<8.1.0.
Additionaly, the pinned black version in reqirements_dev.txt should also be raised to 22.3.0 since it currently breaks the CI (guess that also needs some expected test values to change).
#715 adds this change and more, but due to the broken CI the tests fail.

The recent pallets x.1.0 releases really were anti semantic versioning ones, first jinja2 3.1.0 breaks nbconvert (RTD now pins jinja2<3.1.0 in their docker images) and after that click 8.1.0 breaks black and typer. I also had a lot of updates to do all over the place 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

black being pinned to an older version causes a crash
3 participants