Add source from Eurostat International trade in goods

nbbrd · Feb 24, 2023 · 8fb020e · 8fb020e
1 parent 8870e7d
commit 8fb020e
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,7 +10,9 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 ### Added
 
 - ![API] Add feature descriptor `DATA_QUERY_ALL_KEYWORD`
-- ![SOURCE] Add sources from Directorates General of the European Commission [#414](https://github.com/nbbrd/sdmx-dl/issues/414)
+- ![SOURCE] Add sources from Directorates General of the European
+  Commission [#414](https://github.com/nbbrd/sdmx-dl/issues/414)
+- ![SOURCE] Add source from Eurostat International trade in goods [#415](https://github.com/nbbrd/sdmx-dl/issues/415)
 
 ### Fixed
 
@@ -20,7 +22,8 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 ### Changed
 
 - ![API] Improve request for available key codes
-- ![SOURCE] Improve source from Economic and Social Commission for Asia and the Pacific [#418](https://github.com/nbbrd/sdmx-dl/issues/418)
+- ![SOURCE] Improve source from Economic and Social Commission for Asia and the
+  Pacific [#418](https://github.com/nbbrd/sdmx-dl/issues/418)
 - ![PROVIDER] Improve Eurostat driver [#416](https://github.com/nbbrd/sdmx-dl/issues/416)
 - ![PROVIDER] Add support of `DATA_QUERY_ALL_KEYWORD` feature in RI
 

diff --git a/docs/tmp/sources.csv b/docs/tmp/sources.csv
@@ -9,6 +9,7 @@ EC_DG_EMPL,"European Commission - Directorate General for Employment, Social Aff
 EC_DG_GROW,"European Commission - Directorate General for Internal Market, Industry, Entrepreneurship and SMEs",,ri:estat,,https://webgate.ec.europa.eu/grow/redisstat/api/dissemination/sdmx/2.1,,https://data.europa.eu/data/datasets?catalog=grow,upptime:/nbbrd/sdmx-upptime/EC_DG_GROW,https://nbbrd.github.io/sdmx-upptime/history/ec_dg_grow,en
 ESCAP,Economic and Social Commission for Asia and the Pacific,,ri:sdmx21,,https://api-dataexplorer.unescap.org/rest,detailSupported=true,https://dataexplorer.unescap.org/,upptime:/nbbrd/sdmx-upptime/ESCAP,https://nbbrd.github.io/sdmx-upptime/history/escap,en
 ESTAT,Eurostat,EUROSTAT,ri:estat,,https://ec.europa.eu/eurostat/api/dissemination/sdmx/2.1,,https://ec.europa.eu/eurostat/data/database,upptime:/nbbrd/sdmx-upptime/ESTAT,https://nbbrd.github.io/sdmx-upptime/history/estat,"en,de,fr"
+ESTAT_COMEXT,Eurostat - International trade in goods statistics (ITGS),,ri:estat,,https://ec.europa.eu/eurostat/api/comext/dissemination/sdmx/2.1,,https://ec.europa.eu/eurostat/web/international-trade-in-goods/overview,upptime:/nbbrd/sdmx-upptime/ESTAT_COMEXT,https://nbbrd.github.io/sdmx-upptime/history/estat_comext,en
 ILO,International Labour Organization,,ri:sdmx21,,https://www.ilo.org/sdmx/rest,detailSupported=true,https://ilostat.ilo.org/data/,upptime:/nbbrd/sdmx-upptime/ILO,https://nbbrd.github.io/sdmx-upptime/history/ilo,"en,es,fr"
 IMF,International Monetary Fund,,ri:imf,,http://dataservices.imf.org/REST/SDMX_XML.svc,,https://data.imf.org,upptime:/nbbrd/sdmx-upptime/IMF,https://nbbrd.github.io/sdmx-upptime/history/imf,en
 IMF_SDMX_CENTRAL,International Monetary Fund (SDMX Central),,ri:sdmx21,,https://sdmxcentral.imf.org/ws/public/sdmxapi/rest,detailSupported=true,https://data.imf.org,upptime:/nbbrd/sdmx-upptime/IMF_SDMX_CENTRAL,https://nbbrd.github.io/sdmx-upptime/history/imf-sdmx-central,"en,fr"

diff --git a/...dl-provider-ri/src/main/java/internal/sdmxdl/provider/ri/web/drivers/EurostatDriver2.java b/...dl-provider-ri/src/main/java/internal/sdmxdl/provider/ri/web/drivers/EurostatDriver2.java
@@ -101,6 +101,16 @@ public final class EurostatDriver2 implements WebDriver {
                     .monitorOf("upptime:/nbbrd/sdmx-upptime/ESTAT")
                     .monitorWebsiteOf("https://nbbrd.github.io/sdmx-upptime/history/estat")
                     .build())
+            .source(SdmxWebSource
+                    .builder()
+                    .id("ESTAT_COMEXT")
+                    .name("en", "Eurostat - International trade in goods statistics (ITGS)")
+                    .driver(RI_EUROSTAT)
+                    .endpointOf("https://ec.europa.eu/eurostat/api/comext/dissemination/sdmx/2.1")
+                    .websiteOf("https://ec.europa.eu/eurostat/web/international-trade-in-goods/overview")
+                    .monitorOf("upptime:/nbbrd/sdmx-upptime/ESTAT_COMEXT")
+                    .monitorWebsiteOf("https://nbbrd.github.io/sdmx-upptime/history/estat_comext")
+                    .build())
             .source(SdmxWebSource
                     .builder()
                     .id("EC_DG_COMP")

diff --git a/sdmx-dl-testing/src/main/resources/sdmxdl/testing/xml/Checks.xml b/sdmx-dl-testing/src/main/resources/sdmxdl/testing/xml/Checks.xml
@@ -66,6 +66,12 @@
                   key="..B1GQ." seriesCount="1.." obsCount="12.."/>
         </flow>
     </source>
+    <source name="ESTAT_COMEXT" flowCount="18..">
+        <flow ref="DS-045409" dimCount="6">
+            <data digest="ESTAT_COMEXT"
+                  key=".AT.EU27_2020_EXTRA.TOTAL.." seriesCount="12.." obsCount="1500.."/>
+        </flow>
+    </source>
     <source name="ILO" flowCount="522..">
         <flow ref="DF_SDG_0852_SEX_AGE_RT" dimCount="5">
             <data digest="ILO"