Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source from Statistics Canada #165

Closed
charphi opened this issue Nov 12, 2021 · 3 comments
Closed

Add source from Statistics Canada #165

charphi opened this issue Nov 12, 2021 · 3 comments
Labels
enhancement New feature or request SOURCE
Milestone

Comments

@charphi
Copy link
Member

charphi commented Nov 12, 2021

API documentation: https://www.statcan.gc.ca/en/developers/wds

SdmxWebSource:

Key Value
Name STATCAN
Description Statistics Canada
Aliases
Driver
Dialect
Endpoint https://www150.statcan.gc.ca/t1/wds/rest
Properties
Website https://www150.statcan.gc.ca/n1/en/type/data?MM=1
Monitor

Problems:

  • doesn't follow standard REST API
  • stores frequency in an annotation instead of dimension or attribute
@charphi charphi added enhancement New feature or request SOURCE labels Nov 12, 2021
@charphi charphi added this to the 3.0.0-beta.5 milestone Nov 12, 2021
@charphi
Copy link
Member Author

charphi commented Nov 12, 2021

Done in fb45975

@charphi charphi closed this as completed Nov 12, 2021
@CyLuGh
Copy link

CyLuGh commented Nov 23, 2021

Seems like there are still some troubles with the source:

sdmx-dl list concepts STATCAN 'StatCan:DF_10100139(1.0)' will throw an IOException: Invalid series key '.'

sdmx-dl fetch data STATCAN 'StatCan:DF_10100002(1.0)' '1.1' does have some null data... and I wonder if the symbol used is not yet again something else (might be caused by my recent update to .net 6), I'll have to check.

@charphi
Copy link
Member Author

charphi commented Nov 24, 2021

So, after verification, there are three distinct problems:

  • The command-line parsing of single quote doesn't work as
  • StatCanDriver doesn't validate its DataflowRef input
  • Data parsing is failing due to an invalid xml file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SOURCE
Projects
None yet
Development

No branches or pull requests

2 participants