Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subscription id to relay.subscribe() #440

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Add subscription id to relay.subscribe() #440

merged 1 commit into from
Oct 17, 2024

Conversation

chmac
Copy link
Contributor

@chmac chmac commented Oct 17, 2024 •
edited
Loading

fix #439

It only changes the types because the params argument is passed from .subscribe() to .prepareSubscription() where it is already supported.

@fiatjaf fiatjaf merged commit 0b5b357 into nbd-wtf:master Oct 17, 2024
2 checks passed
@fiatjaf
Copy link
Collaborator

fiatjaf commented Oct 17, 2024

Thank you very much!

@chmac chmac deleted the 439-expose-subscription-id branch October 17, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Option to set subscription id in relay.subscribe()
2 participants
@chmac @fiatjaf