More distinctions between asm blocks and assembly code #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reviewed the entire chapter, and added some more disambiguations in cases of possible ambiguity between the entire
asm!
block (includinglabel
blocks) and the assembly code within it.The second commit, which I've kept separate, attempts to clarify an interaction between
noreturn
andlabel
blocks; however, for that commit I could use some confirmation on accuracy. The phrasing as previously written said that "Anoreturn
asm block behaves just like a function which doesn't return", but that isn't accurate in the presence oflabel
blocks, since the asm block can return, from thelabel
blocks. I changed it to apply to "Anoreturn
asm block with nolabel
blocks". However, this assumes there are not more semantic connotations ofnoreturn
here that do apply to asm blocks withlabel
blocks.