Remove the compiler_builtins dependency
#49
Conversation
| @@ -45,8 +44,7 @@ panic-handler = ["print", "panic"] | |||
| panic-handler-dummy = [] | |||
| system-alloc = [] | |||
| default = ["unwinder", "dwarf-expr", "hide-trace", "fde-phdr-dl", "fde-registry"] | |||
| rustc-dep-of-std = ["core", "gimli/rustc-dep-of-std", "compiler_builtins"] | |||
| compiler_builtins = ["dep:compiler_builtins"] | |||
There was a problem hiding this comment.
I can leave the feature as a nop if you prefer, but I doubt anybody is using it
There was a problem hiding this comment.
Ah, I think these are automatically added by cargo when moving from 2021 to 2024 edition. Can you also remove the core feature and replace rustc-dep-of-std to just depend on dep:core?
There was a problem hiding this comment.
Sure, got rid of it now
Since [1] the crates.io version of `compiler-builtins` is no longer needed as part of `rustc-dep-of-std`, so remove it here. [1]: rust-lang/rust#142265
tgross35
force-pushed
the
remove-compiler-builtins
branch
from
5654d8e to
b620a77
Compare
|
Do you need a new version to be published? |
|
No hurry for this one, the only thing that should currently be broken without it is building xous on xargo - who knows if that worked anyway :) |
|
|
Since 1 the crates.io version of
compiler-builtinsis no longer needed as part ofrustc-dep-of-std, so remove it here.