Skip to content
This repository has been archived by the owner on Jun 16, 2020. It is now read-only.

Add underscore and strikethrough text rendering support #62

Merged
merged 6 commits into from
Aug 17, 2018
Merged

Add underscore and strikethrough text rendering support #62

merged 6 commits into from
Aug 17, 2018

Conversation

nnist
Copy link
Contributor

@nnist nnist commented Aug 15, 2018

I added support for underlined and strikethrough text. pyte already supported it.

Also, I split the lines I added at 80 chars. I'm not sure if this is how you'd like them to be; it is a bit inconsistent in the rest of the code.

@nbedos
Copy link
Owner

nbedos commented Aug 17, 2018

It's all good! I just added default values for some arguments of CharacterCell.new, and I also added a few test cases.

As for line length, I try to stay under 100 characters, except for type hints since they can't be split across multiple lines.

Thanks again!

@nbedos nbedos merged commit cfc2f81 into nbedos:develop Aug 17, 2018
@nbedos nbedos added merged This pull request was merged enhancement New feature or request labels Aug 17, 2018
@nnist nnist deleted the underscore-strikethrough branch August 17, 2018 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request merged This pull request was merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants