Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow output directly to buffer #39

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

iudex-
Copy link
Contributor

@iudex- iudex- commented Feb 5, 2021

I would love to be able to save the merged pdf directly to a buffer

pdfjs supports it as asBuffer(), so i just added it

@mojoaxel mojoaxel self-requested a review February 5, 2021 15:02
Copy link
Collaborator

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mojoaxel mojoaxel merged commit 2c191bb into nbesli:master Feb 5, 2021
@mojoaxel
Copy link
Collaborator

mojoaxel commented Feb 5, 2021

@iudex- Thx!

@iudex-
Copy link
Contributor Author

iudex- commented Feb 5, 2021

That was quick ☺️
Thank you for the library!

@FaridSafi
Copy link

Thank you for your work guys. Looking forward to the new version with saveAsBuffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants