FE.XF.GTK: open console app with --console arg #239
Conversation
aarani
force-pushed
the
addConsoleArg-squashed
branch
2 times, most recently
from
6dbe1e4 to
b131e66
Compare
| </PropertyGroup> | ||
| <Choose> | ||
| <When Condition="'$(BuildFrontendConsoleAsLibrary)'=='true' Or '$(MSBuildRuntimeType)'=='Mono'"> |
There was a problem hiding this comment.
@aarani why filter by Mono here?
There was a problem hiding this comment.
If we only rely on BuildFrontendConsoleAsLibrary , geewallet linux-legacy becomes unbuildable without that property.
There was a problem hiding this comment.
The only reason BuildFrontendConsoleAsLibrary is there, is for stockdotnet6+stockmono lane.
There was a problem hiding this comment.
you know what I'm going to reply to this, right?
aarani
force-pushed
the
addConsoleArg-squashed
branch
from
a2fec37 to
cd0ca70
Compare
Mersho
force-pushed
the
addConsoleArg-squashed
branch
2 times, most recently
from
22ae58c to
6993324
Compare
scripts/make.fsx
Outdated
| @@ -23,8 +23,9 @@ open Fsdk.Process | |||
| open GWallet.Scripting | |||
|
|
|||
| let UNIX_NAME = "geewallet" | |||
| let CONSOLE_FRONTEND = "GWallet.Frontend.Console" | |||
| let GTK_FRONTEND = "GWallet.Frontend.XF.Gtk" | |||
| let SOLUTIONS_PREFIX = "GWallet" | |||
There was a problem hiding this comment.
@Mersho what? this is not a prefix for solutions
Mersho
force-pushed
the
addConsoleArg-squashed
branch
from
6993324 to
c3d1927
Compare
|
Self-reminder: mmm, as part of this PR we should probably include one last commit that runs integration tests with --update-servers parameter on the snap file. |
We wrap Program.fs' funcs inside a 'Program' module because this way they will be able to be invoked from an external assembly.
Last commit was just adding 1-tab indentation.
This commit allows for XF.GTK to open/call console version when passed the "--console" argument. For Frontend.Console to be callable/referenceable from Frontend.XF.GTK, it needs to be built in .netstandard2.0 instead of net6.0, so this commit does that. .NETStandard build happens when either a flag is passed (for stockdotnet6+stockmono lane) or when we're building on mono (for other lanes building XF.GTK).
This commit fixes the repetition of project file names in make.fsx. Co-authored-by: Afshin Arani <afshin@arani.dev>
knocte
force-pushed
the
addConsoleArg-squashed
branch
from
c3d1927 to
ccdb07a
Compare
|
I separated 1st commit in two, so that I could include the 1st one in .git-blame-ignore-revs.
@aarani sorry I still don't understand the reason for this above ^ Why mono? |
|
Superseded by #262 |
This commit allows for XF.GTK to open/call console version when passed the "--console" argument.
For Frontend.Console to be callable/referenceable from Frontend.XF.GTK, it needs to be built in .netstandard2.0 instead of net6.0, this commit does that. .NETStandard build happens when either a flag is passed (for stockdotnet6+stockmono lane) or when we're building on mono (for other lanes building XF.GTK).