Add TLS metrics support #175
Conversation
|
This should use the prometheus/exporter/toolkit web package. |
|
@SuperQ modified to use exporter-toolkit. |
cmd/process-exporter/main.go
Outdated
| @@ -306,6 +308,8 @@ func main() { | |||
| "print manual") | |||
| configPath = flag.String("config.path", "", | |||
| "path to YAML config file") | |||
| tlsConfigFile = flag.String("web.config", "", | |||
There was a problem hiding this comment.
| tlsConfigFile = flag.String("web.config", "", | |
| tlsConfigFile = flag.String("web.config.file", "", |
There was a problem hiding this comment.
Done squash and change in line 311.
|
@SuperQ Hi. How's the plan to merge/release this? |
|
I'm open to merging this PR, if I understand correctly what it does, but I'd like to see some doc changes included first. |
|
Sure, @ncabatoff let me do it. This is to enable TLS in the /metrics endpoint in order to allow use this in secure environment. |
|
@dmaganto - I believe @ncabatoff is waiting to update documentation also. Just pointing to Prometheus documentation https://github.com/prometheus/exporter-toolkit/blob/master/docs/web-configuration.md should be enough I would say. |
|
Yes, you're right. Do you think that should be enough @ncabatoff? |
|
Yeah that would be fine with me, if you mean adding a change to this PR updating the readme to document the new flag and to reference exporter-toolkit's docs re the file format. |
|
@ncabatoff I've added some documentation and reference to get further information to the main project repo. Please take a look. |
|
Thanks! |
No description provided.