Upgrade prometheus/procfs dependency, use Go1.21 #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 23, 2024 17:13
and therefore set Go1.21 in go.mod
|
Thanks! |
zviRosenfeldRedis
added a commit
to RedisLabs/process-exporter
that referenced
this pull request
Jun 16, 2024
* update deps * Finish updating to Go 1.22 * Update Dockerfile for Go 1.22 * Add -recheck-with-time-limit support (ncabatoff#223) process-exporter already supports the -recheck flag which makes it run the whole matching logic on each scrape. This is very useful when trying to monitor processes which change their names shortly after start. Sadly, -recheck carries a rather high performance penalty. At the same time, process name changes are very common directly after start, are seldomly expected during usage. This commit introduces -recheck-with-time-limit which rechecks processes N seconds after their start and stops doing so afterwards. This combines the accuracy benefits of -recheck with the performance gains of not using -recheck. * Fix server start error (ncabatoff#295) * Update release action to use newer actions. Use latest goreleaser version. Use CGO_ENABLED in its config instead of tags. * Upgrade prometheus/procfs dependency, use Go1.21 (ncabatoff#296) * Upgrade prometheus/procfs dependency and therefore set Go1.21 in go.mod * Fix broken compatibility with prometheus/procfs * Update README for Go1.21 --------- Co-authored-by: Thomas Delbende <thomas.delbende@bleemeo.com> * split image workflow from build (ncabatoff#299) Various GHA improvements. * Bump golang.org/x/net from 0.22.0 to 0.23.0 (ncabatoff#298) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.22.0 to 0.23.0. - [Commits](golang/net@v0.22.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nick Cabatoff <nick.cabatoff@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: ncabatoff <ncabatoff@hashicorp.com> Co-authored-by: Christian Hoffmann <christian@hoffie.info> Co-authored-by: AiDaiP <43956964+AiDaiP@users.noreply.github.com> Co-authored-by: Maxi_Mega <52792549+Maxi-Mega@users.noreply.github.com> Co-authored-by: Thomas Delbende <thomas.delbende@bleemeo.com> Co-authored-by: Nick Cabatoff <nick.cabatoff@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prometheus/procfs v0.14.0 introduced a (breaking) change to «Use kernel-compliant types for {U,G}IDs».
In summary, for what this PR addresses, the type of the
UIDsfield ofprocfs.ProcStatuschanged from[4]stringto[4]uint64.Beside that, they also defined Go1.21 as the minimum required version.