Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding reordering option to FragNavTransactionOptions #208

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

EDLuke
Copy link
Contributor

@EDLuke EDLuke commented May 9, 2019

Shared element transition requires reordering to be true.

Edited FavoritesFragment to see the effect using reordering=true and shared element transition. You can notice the edit text has a fading transition when a new fragment is pushed. The same effect will not appear if reordering=false.

@ncapdevi
Copy link
Owner

ncapdevi commented May 9, 2019

@EDLuke First pass at this looks great! I need to spend a little bit more time with the documentation . but it looks like unless explicitly set, it will stick with the defaults. Thanks for the Improvement, Sample, and explanation. I'll try to get to the PR tonight

@EDLuke
Copy link
Contributor Author

EDLuke commented Jun 18, 2019

@ncapdevi have you had the time to take a look at this?

@ncapdevi
Copy link
Owner

@EDLuke Ah, my apologies! Everything looked good at last check. Will carve out some time this evening to merge and release an update. Thanks for the reminder!

@ncapdevi ncapdevi merged commit 456e804 into ncapdevi:master Jun 25, 2019
@ncapdevi
Copy link
Owner

@EDLuke released as 3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants