Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when invalid_assets is not empty #44

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Warn when invalid_assets is not empty #44

merged 2 commits into from
Jun 8, 2021

Conversation

andersy005
Copy link
Member

Fixes #42

@andersy005 andersy005 requested a review from mgrover1 June 7, 2021 22:36
mgrover1
mgrover1 approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks for adding this

@andersy005
Copy link
Member Author

Thank you, @mgrover1!

@andersy005 andersy005 merged commit ceb56b1 into main Jun 8, 2021
@andersy005 andersy005 deleted the warn-on-invalid-assets branch June 8, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrover1 mgrover1 mgrover1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warn when invalid_assets is not empty
2 participants
@andersy005 @mgrover1