Skip to content

Commit

Permalink
Update type hints in core.py and helpers.py
Browse files Browse the repository at this point in the history
  • Loading branch information
andersy005 committed Mar 1, 2024
1 parent 81eb6a1 commit 17b6421
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 7 deletions.
12 changes: 6 additions & 6 deletions jupyter_forward/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ class RemoteRunner:

host: str
port: int = 8888
conda_env: str = None
notebook_dir: str = None
notebook: str = None
conda_env: str | None = None
notebook_dir: str | None = None
notebook: str | None = None
port_forwarding: bool = True
launch_command: str = None
identity: str = None
shell: str = None
launch_command: str | None = None
identity: str | None = None
shell: str | None = None
auth_handler: Callable = _authentication_handler
fallback_auth_handler: Callable = getpass.getpass

Expand Down
7 changes: 6 additions & 1 deletion jupyter_forward/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@
from .console import console


def open_browser(port: int = None, token: str = None, url: str = None, path=None) -> None:
def open_browser(
port: int | None = None,
token: str | None = None,
url: str | None = None,
path: str | None = None,
) -> None:
"""Opens notebook interface in a new browser window.
Parameters
Expand Down

0 comments on commit 17b6421

Please sign in to comment.