-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty NUC_FASTA_OUT #115
Comments
Hi @GomathiNayagam , I don't see a silly error, and I'm having trouble reproducing your issue. With the test data distributed with AMRFinderPlus I get FASTA output:
The results look as I would expect:
Could you paste in what AMRFinderPlus prints to the screen and attach your $NUC_FASTA file? That might help me reproduce your issue. Thanks, |
Hi, This is what the AMRfinder prints out.
|
Thank you for reporting this! |
Yes, it is the 'unusual' FASTA header. It works after editing the headers. |
@GomathiNayagam I'm glad to hear it's working for you. I'm going to reopen just for our tracking because we consider this a bug and plan to release a fix with the next AMRFinderPlus software release. Thanks for reporting! |
Release 3.11.8 - Performance improvements by optimizing blast parameters - Faster 70% single-threaded on nucleotide-only run - Faster by 64% on single-threaded protein-only run - Faster by 58% on single-threaded combined run - Fixed handling for FASTA identifiers with leading underscore "_" ( - Empty NUC_FASTA_OUT #115) - Improved handling of special characters in GFF files - Added --annotation_format standard
AMRFinderPlus release 3.11.14 This release addresses a few issues brought up on GitHub. We weren't able to solve all of them when we couldn't reproduce them, but we are trying. Changes: - On failure no `-o` output file is created - #115 - AMRFinderPlus will now automatically decompress files ending in .gz with gunzip (relies on gunzip being in PATH) - #61 - AMRFinderPlus does not support unicode, but it no longer checks GFF files to prohibit unicode characters specifically - #119 - Add reporting of curl error messages - #120
So the bug itself was fixed in release 3.11.8, but additionally we changed the behavior so if there is an error no empty |
This release addresses a few issues brought up on GitHub. Changes: - On failure no `-o` output file is created - ncbi/amr#115 - AMRFinderPlus will now automatically decompress files ending in .gz with gunzip (this relies on gunzip being in PATH) - ncbi/amr#61 - AMRFinderPlus does not support unicode, but it will not check GFF files to prohibit extended ASCII or UTF-8 characters specifically (still prohibits GFF files with ASCII control characters 0x00 and 0x1F) - ncbi/amr#119 - Add reporting of curl error messages - ncbi/amr#120
Hi,
I am trying to find AMR genes in NUC_FASTA. Though AMRfinder identifies AMR in the input, it outputs an empty NUC_FASTA_OUT. I am probably making a silly error here. Could you help me out?
amrfinder --nucleotide $NUC_FASTA --ident_min 0.9 --coverage_min 0.89 --nucleotide_output out.fasta --threads 6 --output amrout.tsv
The text was updated successfully, but these errors were encountered: