-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a script to pull a new version of an ontology on demand #59
Add a script to pull a new version of an ontology on demand #59
Conversation
this would be a very useful script. |
I have noticed that the script runs owlapi when pulling ontology. Is that really required? It's not really a big deal but owlapi wrapper will be run for the 2nd time when ontology gets processed. |
Yeah, this behavior was already there before my PR. They tested if the remote file was parsable (with owlapi) before creating its corresponding submission. It prevents from getting spammed by submissions for staging changes that don't parse. A possible optimization is to make submissions auto-delete if not parsable and the auto_delete option is set to true e.g I can do that if wanted, but it is beyond this PR, I think. |
Issue
There is only one where the testing if a new file exists, is in the pull_location CRON job . Which is done once a day.
The problem is that if we do an ontology reprocess with the ncbo_ontolgy_process script, it will not test the existence of a new version.
The solutions
There are two ways to solve this
This PR is the implementation of the first proposition.
How to use