Remove redis activesupport #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rack-attack can work with redis directly so there is no need to use redis-activesupport which is no longer being actively developed
this should be reverted back to original after redis 5 copatibilty issues are resolved
Codecov Report
@@ Coverage Diff @@
## develop #120 +/- ##
========================================
Coverage 71.86% 71.86%
========================================
Files 52 52
Lines 2847 2847
========================================
Hits 2046 2046
Misses 801 801
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
This PR can wait until compatibility issues are resolved for redis-client gem. |
|
redis-store v1.10 has been finally released so this PR is ready to be merged |
This was referenced Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove redis-activesupport which was used by rack-attack. Stand-alone redis-activesupport is no longer actively developed and rack-attack can be configured to work without it
redis-rb is upgraded to v5 which resolves
#105
#106
Caveat:
redis-client is pinned to a forked version which includes redis-rb v5 compatibility updates.