Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: extract replace rest_url_prefix to id_url_prefix and and vice versa methods #155

Merged

Conversation

syphax-bouazzouni
Copy link

This RP is a small code refactoring, where I extracted the two methods:

For information: rest_url_prefix and id_url_prefix are defined in the configuration file and are used to separate the prefix URL to be shown in the JSON (rest_url_prefix) from the one that is stored in the triple store (id_url_prefix)

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #155 (65740af) into master (8196bf3) will increase coverage by 0.00%.
The diff coverage is 80.95%.

@@           Coverage Diff           @@
##           master     #155   +/-   ##
=======================================
  Coverage   80.84%   80.84%           
=======================================
  Files          63       63           
  Lines        4835     4856   +21     
=======================================
+ Hits         3909     3926   +17     
- Misses        926      930    +4     
Flag Coverage Δ
unittests 80.84% <80.95%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ontologies_linked_data/serializers/xml.rb 68.96% <0.00%> (ø)
lib/ontologies_linked_data/models/base.rb 70.09% <85.71%> (+2.38%) ⬆️
lib/ontologies_linked_data/monkeypatches/object.rb 71.73% <100.00%> (+1.68%) ⬆️
lib/ontologies_linked_data/serializers/json.rb 80.88% <100.00%> (ø)
...tologies_linked_data/models/ontology_submission.rb 78.74% <0.00%> (-0.55%) ⬇️
lib/ontologies_linked_data/metrics/metrics.rb 79.70% <0.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syphax-bouazzouni syphax-bouazzouni changed the title Extract replace rest_url_prefix to id_url_prefix and and vice versa methods Refactor: extract replace rest_url_prefix to id_url_prefix and and vice versa methods Sep 14, 2022
@mdorf mdorf merged commit 65740af into ncbo:master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants