Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Enhance zipped submissions support - follow up #174

Merged

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Sep 9, 2023

This PR is a fork of @alexskr solution (#172), handling the remaining the not passing test of #144

This iteration uses zlib module, to unzip Gz files (it seems zip module does not handle it).

Thanks, @alexskr for contributing to this.

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #174 (299a01c) into develop (e33a0e4) will increase coverage by 0.04%.
The diff coverage is 87.50%.

@@             Coverage Diff             @@
##           develop     #174      +/-   ##
===========================================
+ Coverage    80.75%   80.80%   +0.04%     
===========================================
  Files           63       63              
  Lines         4901     4907       +6     
===========================================
+ Hits          3958     3965       +7     
+ Misses         943      942       -1     
Flag Coverage Δ
unittests 80.80% <87.50%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/ontologies_linked_data/utils/file.rb 75.22% <87.50%> (+2.32%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants